Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update arm-unknown-linux-gnueabihf. #392

Merged
merged 1 commit into from
Apr 16, 2020
Merged

Update arm-unknown-linux-gnueabihf. #392

merged 1 commit into from
Apr 16, 2020

Conversation

reitermarkus
Copy link
Member

Fixes #391.

@reitermarkus reitermarkus requested review from Dylan-DPC-zz and a team as code owners March 12, 2020 04:01
@reitermarkus reitermarkus force-pushed the arm-unknown-linux-gnueabihf branch 2 times, most recently from e5de2bb to 1d146f4 Compare March 12, 2020 04:20
adamgreig
adamgreig previously approved these changes Mar 12, 2020
View reviewed changes
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Mar 12, 2020
@bors @reitermarkus
Merge #392 #393 #394
1a8b7f0 
392: Update `arm-unknown-linux-gnueabihf`. r=adamgreig a=reitermarkus

Fixes #391.

393: Update CMake to 3.16.5. r=adamgreig a=reitermarkus



394: Fix CI for `i686-apple-darwin`. r=adamgreig a=reitermarkus



Co-authored-by: Markus Reiter <me@reitermark.us>
@bors
Copy link
Contributor

bors bot commented Mar 12, 2020

Build failed (retrying...)

  • rust-embedded.cross

bors bot added a commit that referenced this pull request Mar 12, 2020
@bors @reitermarkus
Merge #392
641ca7b 
392: Update `arm-unknown-linux-gnueabihf`. r=adamgreig a=reitermarkus

Fixes #391.

Co-authored-by: Markus Reiter <me@reitermark.us>
@bors
Copy link
Contributor

bors bot commented Mar 12, 2020

Build failed

  • rust-embedded.cross

@reitermarkus
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Mar 12, 2020
@bors
Try #392:
c2bc068
@bors
Copy link
Contributor

bors bot commented Mar 12, 2020

try

Build succeeded

@reitermarkus
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Mar 13, 2020
@bors
Try #392:
69fa133
@bors
Copy link
Contributor

bors bot commented Mar 13, 2020

try

Build succeeded

@netzdoktor
Copy link

netzdoktor commented Apr 16, 2020 •
edited
Loading

Is there any more testing required to make pull request happen? I would love to do some local checks and see if this solves #391.

@reitermarkus reitermarkus requested a review from a team April 16, 2020 11:14
therealprof
therealprof approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@therealprof
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 16, 2020

Build succeeded:

@bors bors bot merged commit bcdb3d3 into cross-rs:master Apr 16, 2020
@reitermarkus reitermarkus deleted the arm-unknown-linux-gnueabihf branch April 16, 2020 12:07
This was referenced Apr 23, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

@Dylan-DPC-zz Dylan-DPC-zz Awaiting requested review from Dylan-DPC-zz

@adamgreig adamgreig Awaiting requested review from adamgreig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cross-compile for Raspberry Pi Zero W produces segmentation fault
4 participants
@reitermarkus @netzdoktor @therealprof @adamgreig